SDK-6103 Added support for My Account API. by utkrishtsahu · Pull Request #847 · auth0/Auth0.Android

utkrishtsahu · 2025-07-21T03:47:16Z

This PR introduces new sets of API for the MyAccount feature .

Checklist
I have read the Auth0 general contribution guidelines

All existing and new tests complete without errors

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

auth0/src/main/java/com/auth0/android/result/AuthenticationMethod.kt

+    internal class Deserializer : JsonDeserializer<AuthenticationMethod> {
+        override fun deserialize(
+            json: JsonElement,
+            typeOfT: Type,
+            context: JsonDeserializationContext
+        ): AuthenticationMethod? {
+            val jsonObject = json.asJsonObject
+            val type = jsonObject.get("type")?.asString ?: return null
+
+            val targetClass = when (type) {
+                "password" -> PasswordAuthenticationMethod::class.java
+                "passkey" -> PasskeyAuthenticationMethod::class.java
+                "recovery-code" -> MfaRecoveryCodeAuthenticationMethod::class.java
+                "push-notification" -> MfaPushNotificationAuthenticationMethod::class.java
+                "totp" -> MfaTotpAuthenticationMethod::class.java
+                "webauthn-platform" -> WebAuthnPlatformAuthenticationMethod::class.java
+                "webauthn-roaming" -> WebAuthnRoamingAuthenticationMethod::class.java
+                "phone" -> PhoneAuthenticationMethod::class.java
+                "email" -> EmailAuthenticationMethod::class.java
+                else -> UnknownAuthenticationMethod::class.java
+            }
+            return context.deserialize(jsonObject, targetClass)
+        }
+    }


auth0/src/main/java/com/auth0/android/result/EnrollmentChallenge.kt

pmathew92 · 2025-07-21T05:19:35Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

- * You can use the refresh token to get an access token for the My Account API. Refer to [com.auth0.android.authentication.storage.CredentialsManager.getApiCredentials]
- *  , or alternatively [com.auth0.android.authentication.AuthenticationAPIClient.renewAuth] if you are not using CredentialsManager.
+ * You can use a refresh token to get an access token for the My Account API.
+ * Refer to `CredentialsManager#getApiCredentials` or `AuthenticationAPIClient#renewAuth`.


Why was the comment changed ? Ensure the comments convey as much detail as possible including samples wherever applicable

pmathew92 · 2025-07-21T05:20:23Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

 * ```kotlin
- * val auth0 = Auth0.getInstance("YOUR_CLIENT_ID", "YOUR_DOMAIN")
- * val client = MyAccountAPIClient(auth0,accessToken)
+ * val auth0 = Auth0("YOUR_CLIENT_ID", "YOUR_DOMAIN")


val auth0 = Auth0.getInstance("YOUR_CLIENT_ID", "YOUR_DOMAIN") is the correct way to access an Auth0 instance . Please correct in the comment

pmathew92 · 2025-07-22T10:53:28Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

+    public fun updateAuthenticationMethodById(
+        authenticationMethodId: String,
+        preferredAuthenticationMethod: String,
+        authenticationMethodName: String


These are optional parameters

Please make them as optional .Check with @NandanPrabhu

…nd modifying Email, Phone, and TOTP Verification verifyOtp(...)

auth0/src/main/java/com/auth0/android/result/EnrollmentChallenge.kt

pmathew92 · 2025-07-28T11:22:06Z

auth0/src/main/java/com/auth0/android/result/EnrollmentChallenge.kt

+    public val recoveryCode: String
+) : EnrollmentChallenge(id, authSession)
+
+public data class PublicKeyCredentialCreationOptions(


This seems to be a duplicate of AuthnParamsPublicKey data class in the PasskeyRegistrationChallenge.kt file

pmathew92 · 2025-07-28T11:36:13Z

auth0/src/main/java/com/auth0/android/result/EnrollmentPayload.kt

+    public val identityUserId: String?
+) : EnrollmentPayload("passkey")
+
+public data class WebAuthnPlatformEnrollmentPayload(


This can be a normal class ?

public class WebAuthnPlatformEnrollmentPayload() : EnrollmentPayload("webauthn-roaming")

This way you don't have to add an empty placeholder for the data class

maintain consistency within the EnrollmentPayload sealed class hierarchy.

normal class can also be part of sealed class ?

pmathew92 · 2025-07-28T11:36:26Z

auth0/src/main/java/com/auth0/android/result/EnrollmentPayload.kt

+
+public data class WebAuthnRoamingEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("webauthn-roaming")


Same as above

aintain consistency within the EnrollmentPayload sealed class hierarchy.

pmathew92 · 2025-07-28T11:36:33Z

auth0/src/main/java/com/auth0/android/result/EnrollmentPayload.kt

+
+public data class TotpEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("totp")


aintain consistency within the EnrollmentPayload sealed class hierarchy.

pmathew92 · 2025-07-28T11:36:42Z

auth0/src/main/java/com/auth0/android/result/EnrollmentPayload.kt

+) : EnrollmentPayload("totp")
+
+public data class PushNotificationEnrollmentPayload(
+    private val placeholder: String? = null


aintain consistency within the EnrollmentPayload sealed class hierarchy.

pmathew92 · 2025-07-28T11:36:46Z

auth0/src/main/java/com/auth0/android/result/EnrollmentPayload.kt

+) : EnrollmentPayload("push-notification")
+
+public data class RecoveryCodeEnrollmentPayload(
+    private val placeholder: String? = null


aintain consistency within the EnrollmentPayload sealed class hierarchy.

pmathew92 · 2025-07-28T11:43:16Z

auth0/src/main/java/com/auth0/android/result/PasskeyAuthenticationMethod.kt

-    @SerializedName("user_handle")
-    val userHandle: String
-)
+public typealias PasskeyAuthenticationMethod = AuthenticationMethod


The AuthenticationMethod data class has some mandatory property like usage which the passkeys response might not send . Please cross check them and test this to avoid run time crashes

current code has been updated to use a dedicated data class PasskeyAuthenticationMethod(...) which inherits from the AuthenticationMethod sealed class

auth0/src/main/java/com/auth0/android/result/PasskeyEnrollmentChallenge.kt

pmathew92 · 2025-07-28T11:46:53Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

-import com.auth0.android.request.JsonAdapter
-import com.auth0.android.request.PublicKeyCredentials
-import com.auth0.android.request.Request
+import com.auth0.android.request.*


Please configure your IDE to have specific imports instead of generic one

pmathew92 · 2025-07-28T11:49:27Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

+     */
+    public fun updateAuthenticationMethodById(
+        authenticationMethodId: String,
+        preferredAuthenticationMethod: String,


lets limit the preferredAuthenticationMethod type to the accepted values of sms and voice . Lets use an enum type here with string default value

done added enum for the same

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

pmathew92 · 2025-07-28T11:51:30Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

+     * val apiClient = MyAccountAPIClient(auth0, accessToken)
+     *
+     * apiClient.enrollPhone("+11234567890", "sms")
+     *        .start(object : Callback<EnrollmentChallenge, MyAccountException> {


Format the code samples

Fix the indentation

done for all KDOC in [MyAccountAPIClient.kt]

pmathew92 · 2025-07-28T11:52:14Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

+     * @param preferredMethod The preferred method for this factor ("sms" or "voice").
+     * @return a request that will yield an enrollment challenge.
+     */
+    public fun enrollPhone(phoneNumber: String, preferredMethod: String): Request<EnrollmentChallenge, MyAccountException> {


As discussed above ,lets have the preferred method as an enum type

added new enum for the same

NandanPrabhu · 2025-08-19T07:10:55Z

auth0/src/main/java/com/auth0/android/result/EnrollmentChallenge.kt

+    @SerializedName("barcode_uri")
+    public val barcodeUri: String,
+    @SerializedName("manual_input_code")
+    public val manualInputCode: String


manualInputCode must be optional.we dont get it incase of push notification factor

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

Copilot

Pull Request Overview

This PR introduces comprehensive My Account API support for managing user authentication methods, including enrollment, verification, and CRUD operations for various multi-factor authentication (MFA) methods.

Key changes include:

New API methods for authentication method management (CRUD operations)
Support for enrolling multiple authentication types (email, phone, TOTP, recovery codes)
Comprehensive verification methods for OTP and non-OTP authentication factors
Enhanced data models with proper JSON serialization for various authentication method types

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
`MyAccountAPIClient.kt`	Core client implementation with new API methods for authentication method management and enrollment flows
`MyAccountAPIClientTest.kt`	Comprehensive test coverage for all new API endpoints and functionality
`AuthenticationMethod.kt`	Sealed class hierarchy for different authentication method types with JSON deserialization
`EnrollmentChallenge.kt`	Sealed class for enrollment challenges with custom deserializer logic
`EnrollmentPayload.kt`	Sealed class hierarchy for enrollment request payloads
`Factor.kt`	Simple data class for factor information
`Factors.kt`	Wrapper class for factor list responses
`ErrorResponse.kt`	Standardized error response structure
`VerificationPayload.kt`	Data class for OTP verification requests
`PasskeyEnrollmentChallenge.kt`	Simplified passkey enrollment challenge without JSON annotations
`PasskeyAuthenticationMethod.kt`	Removed standalone passkey authentication method (now part of sealed class hierarchy)
`PhoneAuthenticationMethod.kt`	Enum for phone authentication method types

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

Copilot · 2025-09-04T04:50:17Z

auth0/src/main/java/com/auth0/android/result/EnrollmentPayload.kt

+public data class WebAuthnPlatformEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("webauthn-platform")
+
+public data class WebAuthnRoamingEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("webauthn-roaming")
+
+public data class TotpEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("totp")
+
+public data class PushNotificationEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("push-notification")
+
+public data class RecoveryCodeEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("recovery-code")


[nitpick] Multiple classes use identical placeholder properties that serve no functional purpose. Consider using object declarations instead of data classes for payload types that don't require additional properties, or remove the placeholder entirely if not needed for serialization.

Suggested change

public data class WebAuthnPlatformEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("webauthn-platform")

public data class WebAuthnRoamingEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("webauthn-roaming")

public data class TotpEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("totp")

public data class PushNotificationEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("push-notification")

public data class RecoveryCodeEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("recovery-code")

public object WebAuthnPlatformEnrollmentPayload : EnrollmentPayload("webauthn-platform")

public object WebAuthnRoamingEnrollmentPayload : EnrollmentPayload("webauthn-roaming")

public object TotpEnrollmentPayload : EnrollmentPayload("totp")

public object PushNotificationEnrollmentPayload : EnrollmentPayload("push-notification")

public object RecoveryCodeEnrollmentPayload : EnrollmentPayload("recovery-code")

Copilot · 2025-09-04T04:50:18Z

auth0/src/main/java/com/auth0/android/result/EnrollmentPayload.kt

+public data class WebAuthnPlatformEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("webauthn-platform")
+
+public data class WebAuthnRoamingEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("webauthn-roaming")
+
+public data class TotpEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("totp")
+
+public data class PushNotificationEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("push-notification")
+
+public data class RecoveryCodeEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("recovery-code")


[nitpick] Multiple classes use identical placeholder properties that serve no functional purpose. Consider using object declarations instead of data classes for payload types that don't require additional properties, or remove the placeholder entirely if not needed for serialization.

Suggested change

public data class WebAuthnPlatformEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("webauthn-platform")

public data class WebAuthnRoamingEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("webauthn-roaming")

public data class TotpEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("totp")

public data class PushNotificationEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("push-notification")

public data class RecoveryCodeEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("recovery-code")

public object WebAuthnPlatformEnrollmentPayload : EnrollmentPayload("webauthn-platform")

public object WebAuthnRoamingEnrollmentPayload : EnrollmentPayload("webauthn-roaming")

public object TotpEnrollmentPayload : EnrollmentPayload("totp")

public object PushNotificationEnrollmentPayload : EnrollmentPayload("push-notification")

public object RecoveryCodeEnrollmentPayload : EnrollmentPayload("recovery-code")

Copilot · 2025-09-04T04:50:18Z

auth0/src/main/java/com/auth0/android/result/EnrollmentPayload.kt

+public data class WebAuthnPlatformEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("webauthn-platform")
+
+public data class WebAuthnRoamingEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("webauthn-roaming")
+
+public data class TotpEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("totp")
+
+public data class PushNotificationEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("push-notification")
+
+public data class RecoveryCodeEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("recovery-code")


[nitpick] Multiple classes use identical placeholder properties that serve no functional purpose. Consider using object declarations instead of data classes for payload types that don't require additional properties, or remove the placeholder entirely if not needed for serialization.

Suggested change

public data class WebAuthnPlatformEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("webauthn-platform")

public data class WebAuthnRoamingEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("webauthn-roaming")

public data class TotpEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("totp")

public data class PushNotificationEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("push-notification")

public data class RecoveryCodeEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("recovery-code")

public object WebAuthnPlatformEnrollmentPayload : EnrollmentPayload("webauthn-platform")

public object WebAuthnRoamingEnrollmentPayload : EnrollmentPayload("webauthn-roaming")

public object TotpEnrollmentPayload : EnrollmentPayload("totp")

public object PushNotificationEnrollmentPayload : EnrollmentPayload("push-notification")

public object RecoveryCodeEnrollmentPayload : EnrollmentPayload("recovery-code")

Copilot · 2025-09-04T04:50:18Z

auth0/src/main/java/com/auth0/android/result/EnrollmentPayload.kt

+public data class WebAuthnPlatformEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("webauthn-platform")
+
+public data class WebAuthnRoamingEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("webauthn-roaming")
+
+public data class TotpEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("totp")
+
+public data class PushNotificationEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("push-notification")
+
+public data class RecoveryCodeEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("recovery-code")


[nitpick] Multiple classes use identical placeholder properties that serve no functional purpose. Consider using object declarations instead of data classes for payload types that don't require additional properties, or remove the placeholder entirely if not needed for serialization.

Suggested change

public data class WebAuthnPlatformEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("webauthn-platform")

public data class WebAuthnRoamingEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("webauthn-roaming")

public data class TotpEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("totp")

public data class PushNotificationEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("push-notification")

public data class RecoveryCodeEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("recovery-code")

public object WebAuthnPlatformEnrollmentPayload : EnrollmentPayload("webauthn-platform")

public object WebAuthnRoamingEnrollmentPayload : EnrollmentPayload("webauthn-roaming")

public object TotpEnrollmentPayload : EnrollmentPayload("totp")

public object PushNotificationEnrollmentPayload : EnrollmentPayload("push-notification")

public object RecoveryCodeEnrollmentPayload : EnrollmentPayload("recovery-code")

Copilot · 2025-09-04T04:50:18Z

auth0/src/main/java/com/auth0/android/result/EnrollmentPayload.kt

+public data class WebAuthnPlatformEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("webauthn-platform")
+
+public data class WebAuthnRoamingEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("webauthn-roaming")
+
+public data class TotpEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("totp")
+
+public data class PushNotificationEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("push-notification")
+
+public data class RecoveryCodeEnrollmentPayload(
+    private val placeholder: String? = null
+) : EnrollmentPayload("recovery-code")


[nitpick] Multiple classes use identical placeholder properties that serve no functional purpose. Consider using object declarations instead of data classes for payload types that don't require additional properties, or remove the placeholder entirely if not needed for serialization.

Suggested change

public data class WebAuthnPlatformEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("webauthn-platform")

public data class WebAuthnRoamingEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("webauthn-roaming")

public data class TotpEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("totp")

public data class PushNotificationEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("push-notification")

public data class RecoveryCodeEnrollmentPayload(

private val placeholder: String? = null

) : EnrollmentPayload("recovery-code")

public object WebAuthnPlatformEnrollmentPayload : EnrollmentPayload("webauthn-platform")

public object WebAuthnRoamingEnrollmentPayload : EnrollmentPayload("webauthn-roaming")

public object TotpEnrollmentPayload : EnrollmentPayload("totp")

public object PushNotificationEnrollmentPayload : EnrollmentPayload("push-notification")

public object RecoveryCodeEnrollmentPayload : EnrollmentPayload("recovery-code")

auth0/src/test/java/com/auth0/android/myaccount/MyAccountAPIClientTest.kt

pmathew92 · 2025-09-04T05:09:59Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

-                    )
+                    val location = (metadata[LOCATION_KEY] as? List<*>)?.filterIsInstance<String>()?.firstOrNull()
+                    val authId = location?.split("/")?.lastOrNull()?.let { URLDecoder.decode(it, "UTF-8") }
+                        ?: throw MyAccountException("Authentication method ID not found in Location header.")


nit: Continuous chaining may affect the readability of the code especially for such a long set of actions. Ensure the code is readable and easier to understand

made readable avoided chaining.

pmathew92 · 2025-09-04T05:11:50Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

-        val post = factory.post(url.toString(), passkeyEnrollmentAdapter)
-            .addParameters(params)
+        return factory.post(url.toString(), passkeyEnrollmentAdapter)
+            .addParameters(params.mapValues { it.value.toString() }) // FIX: Safely convert map values to String


What is the need for this change.params is already a dictionary of strings

pmathew92 · 2025-09-04T05:12:28Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

+            .asDictionary()
+
+        return factory.post(url.toString(), GsonAdapter(PasskeyAuthenticationMethod::class.java, gson))
+            .addParameters(params.mapValues { it.value.toString() }) // FIX: Safely convert map values to String


Same as above

pmathew92 · 2025-09-04T05:17:38Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

-            PasskeyAuthenticationMethod::class.java
-        )
+        return factory.patch(url.toString(), GsonAdapter(AuthenticationMethod::class.java, gson))
+            .addParameters(params.mapValues { it.value.toString() })


Same as above

Seems to be a confusion. The change to be done is .addParameters(params) . Why do you need to add mapValues to the params. It is already a map of String. Check any of the existing api in AuthenticationAPIClient or passkeys above. We are just passing params as such.

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

pmathew92 · 2025-09-04T05:21:02Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

+     *
+     * apiClient.enrollEmail("user@example.com")
+     *         .start(object : Callback<EnrollmentChallenge, MyAccountException> {
+     *               override fun onSuccess(result: EnrollmentChallenge) {


Fix the indentation

pmathew92 · 2025-09-04T05:21:39Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

+     *                  override fun onSuccess(result: EnrollmentChallenge) {
+     *          // The result will be a TotpEnrollmentChallenge containing a barcode_uri
+     *                 Log.d("MyApp", "Enrollment started for Push Notification.")
+     *                }


Fix the indentation

pmathew92 · 2025-09-04T05:23:10Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

+    private fun createEnrollmentRequest(params: Map<String, Any>): Request<EnrollmentChallenge, MyAccountException> {
+        val url = getDomainUrlBuilder().addPathSegment(AUTHENTICATION_METHODS).build()
+        return factory.post(url.toString(), GsonAdapter(EnrollmentChallenge::class.java, gson))
+            .addParameters(params.mapValues { it.value.toString() }) // FIX: Safely convert map values to String


Where is the parameter being created in this method ?

Changed the name for more clarity and refactored the code.

auth0/src/main/java/com/auth0/android/myaccount/PhoneAuthenticationMethod.kt

pmathew92 · 2025-09-04T05:29:11Z

auth0/src/main/java/com/auth0/android/result/ErrorResponse.kt

+
+/**
+ * Represents a standardized error response from the My Account API.
+ */


these are already defined in the MyAccountException class . What is the need to redefine this ?

ErrorResponse: This class is a pure Data Transfer Object (DTO). Its structure is a direct 1-to-1 mapping of the JSON error payload defined in the OpenAPI specification. It represents the raw error data from the server.

MyAccountException: This is the actual exception class that our SDK uses to signal a failure to the developer. It consumes the data from the error response but also adds SDK-specific context, like the ability to wrap an underlying cause (e.g., a network error).

Yes I understand that. What I meant is ,the error you receive from the API is mapped to MyAccountException in the network layer. The above parameters are already defined in that class which the user can access . I also don't see any usage of this class also in the code. So delete it ,if not being used

removed [ErrorResponse.kt]

pmathew92 · 2025-09-04T05:45:57Z

Add the samples in Example.md file
Also there are some indendation issues on code samples in the comments. Fix them as well

… updated Example.md file

pmathew92 · 2025-09-04T14:07:09Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

-            PasskeyAuthenticationMethod::class.java
-        )
+        return factory.patch(url.toString(), GsonAdapter(AuthenticationMethod::class.java, gson))
+            .addParameters(params.mapValues { it.value.toString() })


Seems to be a confusion. The change to be done is .addParameters(params) . Why do you need to add mapValues to the params. It is already a map of String. Check any of the existing api in AuthenticationAPIClient or passkeys above. We are just passing params as such.

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

pmathew92 · 2025-09-08T07:44:29Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

+        return buildEnrollmentRequest(params)
+    }
+
+    private fun buildEnrollmentRequest(params: Map<String, Any>): Request<EnrollmentChallenge, MyAccountException> {


This can be Map<String,String> . Or any place you are sending anything other than String ?

pmathew92 · 2025-09-08T07:46:39Z

EXAMPLES.md

+**Scopes required:** `read:me:factors`
+```kotlin
+myAccountClient.getFactors()
+    .start(object : Callback<Factors, MyAccountException> {


this is List in the actual method. Correct it here

pmathew92 · 2025-09-08T07:46:56Z

EXAMPLES.md

+
+```java
+myAccountClient.getFactors()
+    .start(new Callback<Factors, MyAccountException>() {


List . Need to be corrected here

pmathew92 · 2025-09-08T07:48:26Z

EXAMPLES.md

+myAccountClient.enrollTotp()
+    .start(object : Callback<EnrollmentChallenge, MyAccountException> {
+        override fun onSuccess(result: EnrollmentChallenge) {
+            val totpChallenge = result as TotpEnrollmentChallenge


Why do the users need to explicitly cast them to TotpEnrollmentChallenge ? Why can't we return an instance of TotpEnrollmentChallenge ?

Might want to make the necessary changes in line 1112 and 1113

pmathew92 · 2025-09-08T07:48:37Z

EXAMPLES.md

+myAccountClient.enrollPushNotification()
+    .start(object : Callback<EnrollmentChallenge, MyAccountException> {
+        override fun onSuccess(result: EnrollmentChallenge) {
+            val pushChallenge = result as TotpEnrollmentChallenge // Uses the same response format as TOTP


Same as above

Necessary changes in line 1142 and 1143

pmathew92 · 2025-09-08T07:48:43Z

EXAMPLES.md

+    .start(new Callback<EnrollmentChallenge, MyAccountException>() {
+        @Override
+        public void onSuccess(EnrollmentChallenge result) {
+            TotpEnrollmentChallenge pushChallenge = (TotpEnrollmentChallenge) result;


Same as above

Changes in line 1157 and 1158

pmathew92 · 2025-09-08T07:49:14Z

EXAMPLES.md

+myAccountClient.enrollRecoveryCode()
+    .start(object : Callback<EnrollmentChallenge, MyAccountException> {
+        override fun onSuccess(result: EnrollmentChallenge) {
+            val recoveryChallenge = result as RecoveryCodeEnrollmentChallenge


Why can't we return an instance of RecoveryCodeEnrollmentChallenge ?

Changes in line 1173 and 1174

pmathew92 · 2025-09-10T11:05:28Z

EXAMPLES.md

+        @Override
+        public void onSuccess(RecoveryCodeEnrollmentChallenge result) {
+            RecoveryCodeEnrollmentChallenge recoveryChallenge = (RecoveryCodeEnrollmentChallenge) result;
+            // Display and require the user to save recoveryChallenge.getRecoveryCode()


Changes in line 1190

pmathew92 · 2025-09-10T11:13:52Z

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt

+    }
+
+    /**
+     * Confirms the enrollment for factors that do not require an OTP, like Push Notification or Recovery Code.


Adding the like Push Notification or Recovery Code. may convey the wrong message that this method can be used for push notification and recovery code. Either remove this or convey it to avoid any confusion

Added support for My Account API

c8243e3

utkrishtsahu requested a review from a team as a code owner July 21, 2025 03:47

github-advanced-security bot found potential problems Jul 21, 2025

View reviewed changes

pmathew92 reviewed Jul 21, 2025

View reviewed changes

utkrishtsahu added 2 commits July 22, 2025 10:19

Refactor the code with SDK-6075's changes

58ebd47

Added few more payloads

c0703ad

pmathew92 reviewed Jul 22, 2025

View reviewed changes

utkrishtsahu added 2 commits July 24, 2025 10:48

adding Push Notification verify(...) and Recovery Code Verification a…

a702900

…nd modifying Email, Phone, and TOTP Verification verifyOtp(...)

adding KDoc for methods with Usage

13da6ba

pmathew92 reviewed Jul 28, 2025

View reviewed changes

auth0/src/main/java/com/auth0/android/result/EnrollmentChallenge.kt Show resolved Hide resolved

pmathew92 reviewed Jul 28, 2025

View reviewed changes

auth0/src/main/java/com/auth0/android/result/PasskeyEnrollmentChallenge.kt Show resolved Hide resolved

pmathew92 reviewed Jul 28, 2025

View reviewed changes

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt Show resolved Hide resolved

pmathew92 reviewed Jul 28, 2025

View reviewed changes

pmathew92 mentioned this pull request Aug 12, 2025

Added support for My Account API [DO NOT MERGE] #842

Closed

6 tasks

utkrishtsahu added 2 commits August 19, 2025 10:43

Added UT test caes and changes excluding WebAuthn

c42e67f

Refactored code removed comments

eddddc0

pmathew92 requested a review from Copilot August 19, 2025 05:20

This comment was marked as outdated.

Sign in to view

NandanPrabhu reviewed Aug 19, 2025

View reviewed changes

Incorporated all review comments and refactored the code

25b4e13

github-advanced-security bot found potential problems Sep 4, 2025

View reviewed changes

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt Fixed Show fixed Hide fixed

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt Fixed Show fixed Hide fixed

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt Fixed Show fixed Hide fixed

main' into SDK-6103-My-Account-Auth-Methods-Android-Support

6ae1fe1

pmathew92 requested a review from Copilot September 4, 2025 04:48

Copilot AI reviewed Sep 4, 2025

View reviewed changes

pmathew92 reviewed Sep 4, 2025

View reviewed changes

auth0/src/main/java/com/auth0/android/myaccount/MyAccountAPIClient.kt Show resolved Hide resolved

pmathew92 reviewed Sep 4, 2025

View reviewed changes

auth0/src/main/java/com/auth0/android/myaccount/PhoneAuthenticationMethod.kt Show resolved Hide resolved

pmathew92 reviewed Sep 4, 2025

View reviewed changes

utkrishtsahu added 2 commits September 4, 2025 19:15

Incorporated review comments and added Sample in EXAMPLE.md

93c507b

Changed authentication method according to review comments and params…

5a71404

… updated Example.md file

pmathew92 reviewed Sep 8, 2025

View reviewed changes

Made updateAuthenticationMethodById internal and fixed review change

db02f71

pmathew92 reviewed Sep 10, 2025

View reviewed changes

Example.md file change

bb3adc3

pmathew92 previously approved these changes Sep 10, 2025

View reviewed changes

Enhancement EXAMPLE.md file

4689ff3

utkrishtsahu dismissed pmathew92’s stale review via 4689ff3 September 12, 2025 08:29

pmathew92 approved these changes Sep 12, 2025

View reviewed changes

utkrishtsahu merged commit 86a90e7 into main Sep 12, 2025
6 checks passed

utkrishtsahu deleted the SDK-6103-My-Account-Auth-Methods-Android-Support branch September 12, 2025 11:07

utkrishtsahu mentioned this pull request Sep 12, 2025

Release 3.10.0 #868

Merged

Conversation

utkrishtsahu commented Jul 21, 2025

Uh oh!

Uh oh!

Check notice

Copilot Autofix

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pmathew92 Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

utkrishtsahu Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pmathew92 Sep 4, 2025 •

edited

Loading

utkrishtsahu Sep 4, 2025 •

edited

Loading